Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • hub-connector hub-connector
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Redmine
    • Redmine
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • Gambio HubGambio Hub
  • hub-connectorhub-connector
  • Merge requests
  • !8

Cleanup

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Marco Bruchmann requested to merge cleanup into develop May 27, 2021
  • Overview 0
  • Commits 3
  • Pipelines 0
  • Changes 387+

What’s been done here and why:

  • src and the most recent variant MUST be identical
  • variants may only differ from one another in those areas that warrant the existence of the variants in the first place
  • identical means identical! no added/removed whitespace, no reformatting
  • yes, some of the code is ugly. you still may not reformat it unless it’s the smallest possible block enclosing the changes you may have made.
  • it MUST be possible to find the real differences between variants quickly with phpStorm’s file comparison tool without wading through dozens of false positives caused by added/removed whitespace
  • if we don’t meticulously adhere to these rules maintenance of the variants quickly turns into hell on earth
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: cleanup